Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes consume ref prop during SSR, too #28731

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Classes consume ref prop during SSR, too #28731

merged 1 commit into from
Apr 3, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 3, 2024

Same as #28719 but for SSR.

@acdlite acdlite requested a review from kassens April 3, 2024 15:38
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 3, 2024
@react-sizebot
Copy link

Comparing: 7a2609e...153d2d6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 169.31 kB 169.31 kB = 52.76 kB 52.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.13 kB 171.13 kB = 53.33 kB 53.33 kB
facebook-www/ReactDOM-prod.classic.js = 589.03 kB 589.03 kB = 103.68 kB 103.68 kB
facebook-www/ReactDOM-prod.modern.js = 566.05 kB 566.05 kB = 99.59 kB 99.59 kB
test_utils/ReactAllWarnings.js Deleted 64.60 kB 0.00 kB Deleted 16.14 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.classic.js +0.45% 205.02 kB 205.94 kB +0.15% 37.39 kB 37.44 kB
oss-stable-semver/react-server/cjs/react-server.production.js +0.32% 154.13 kB 154.61 kB +0.30% 36.37 kB 36.48 kB
oss-stable/react-server/cjs/react-server.production.js +0.32% 154.13 kB 154.61 kB +0.30% 36.37 kB 36.48 kB
oss-experimental/react-server/cjs/react-server.production.js +0.29% 165.62 kB 166.11 kB +0.31% 38.29 kB 38.41 kB
oss-stable-semver/react-server/cjs/react-server.production.min.js +0.29% 37.37 kB 37.48 kB +0.33% 11.94 kB 11.97 kB
oss-stable/react-server/cjs/react-server.production.min.js +0.29% 37.37 kB 37.48 kB +0.33% 11.94 kB 11.97 kB
oss-experimental/react-server/cjs/react-server.production.min.js +0.27% 40.61 kB 40.72 kB +0.37% 12.80 kB 12.85 kB
oss-stable-semver/react-server/cjs/react-server.development.js +0.25% 196.53 kB 197.02 kB +0.25% 46.42 kB 46.53 kB
oss-stable/react-server/cjs/react-server.development.js +0.25% 196.53 kB 197.02 kB +0.25% 46.42 kB 46.53 kB
oss-experimental/react-server/cjs/react-server.development.js +0.24% 207.99 kB 208.48 kB +0.22% 48.38 kB 48.48 kB
test_utils/ReactAllWarnings.js Deleted 64.60 kB 0.00 kB Deleted 16.14 kB 0.00 kB

Generated by 🚫 dangerJS against 153d2d6

kassens
kassens approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the default prop resolution happening? In the JSX runtime?

@acdlite
Copy link
Collaborator Author

acdlite commented Apr 3, 2024

Yes, until my next PR

@acdlite acdlite merged commit 3761acb into facebook:main Apr 3, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
@acdlite
Classes consume ref prop during SSR, too (#28731)
a491103 
Same as #28719 but for SSR.

DiffTrain build for [3761acb](3761acb)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@acdlite @AndyPengc12
Classes consume ref prop during SSR, too (facebook#28731)
7306077 
Same as facebook#28719 but for SSR.
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@kassens kassens kassens approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acdlite @react-sizebot @kassens @sebmarkbage @facebook-github-bot